baseAppView: Destroy icon when removing

We cannot rely on the garbage collector to do that in a timely
manner, so destroy it explicitly.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a49ebe09a899cab1df0ccaee0788e56eb9870d8b..5b9d4d87fa70c8b3b8a6d9db2e91f950836afaa1 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -186,10 +186,11 @@ var BaseAppView = GObject.registerClass({
         // Remove old app icons
         removedApps.forEach(icon => {
             let iconIndex = this._allItems.indexOf(icon);
+            let id = icon.id;
 
             this._allItems.splice(iconIndex, 1);
-            this._grid.removeItem(icon);
-            delete this._items[icon.id];
+            icon.destroy();
+            delete this._items[id];
         });
 
         // Add new app icons